-
Notifications
You must be signed in to change notification settings - Fork 265
FIX: Remove trace by default #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A test to check you removed the correct volume? |
No problem with putting in the release. I'm still writing docs, so another day suits me OK. |
Cool. I'll try throwing Appveyor in here, too. :) |
a29e623
to
eade99f
Compare
eade99f
to
03f21ad
Compare
Okay, Travis and Appveyor are happy, and I made the test more comprehensive. Ready for review/merge from my end. The badges I added to the README should update after merge. If you don't want them there, I can remove them. |
I think the Any way we could submodule that file to keep up to date with Olivier's changes? A bit 50:50 on the travis badge, because travis-ci is so unreliable, can fail and give us bad press when there's nothing wrong. |
Hah: https://github.com/blog/1935-see-results-from-all-pull-request-status-checks I'll undo |
I trimmed the |
WDYT about keeping the Coveralls badge? 94% is awesome. But I guess if Travis goes wrong, you might get that one messed up, too... |
Coveralls badge is fine, totally agree about the 94% ! Do you think it is possible to get the appveyor commands working for Python.org Python? It's the Python most people are likely to be using... |
Yeah, the drawback is substantially increased testing time because |
I can't practically futz with the web stuff from here I'm afraid, but sure, miniconda considerably better than nothing, thanks again. Last I heard on this : |
Alright, Travis and Appveyor are happy, and I kept only the Coveralls badge. Ready for review/merge from my end. |
Thanks, merging. |
FIX: Remove trace by default Allows for discarding the trace, and making it the default behavior. It generally seems to be nuisance (non-)data in the analysis process. Add appveyor build and badge.
FIX: Remove trace by default Allows for discarding the trace, and making it the default behavior. It generally seems to be nuisance (non-)data in the analysis process. Add appveyor build and badge.
Allows for discarding the trace, and making it the default behavior. It generally seems to be nuisance (non-)data in the analysis process.