BF: work around np.allclose float128 bug #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-brett
force-pushed
the
workaround-allclose-bug
branch
from
9533145 to
503c00c
Compare
|
Any comments here? |
Numpy 1.9.2 allclose thinks that np.inf in float128 precision is not allclose to itself. Work round with expanded assert_allclose_safely function.
matthew-brett
force-pushed
the
workaround-allclose-bug
branch
from
503c00c to
593a7d4
Compare
|
fwiw with such extensive test I do not have a concern... send to be doing the right thing :-) |
|
:) - OK - I'll merge then. Thanks for taking a look. |
matthew-brett
added a commit
that referenced
this pull request
Apr 2, 2015
MRG: work around np.allclose float128 bug Numpy 1.9.2 allclose thinks that np.inf in float128 precision is not allclose to itself. Work round with expanded assert_allclose_safely function.
grlee77
pushed a commit
to grlee77/nibabel
that referenced
this pull request
Mar 15, 2016
MRG: work around np.allclose float128 bug Numpy 1.9.2 allclose thinks that np.inf in float128 precision is not allclose to itself. Work round with expanded assert_allclose_safely function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 1.9.2 allclose thinks that np.inf in float128 precision is not allclose
to itself. Work round with expanded assert_allclose_safely function.
See: http://nipy.bic.berkeley.edu/builders/nibabel-py2.7-osx-10.6/builds/178/steps/shell_4/logs/stdio for resulting error, maybe fixed by this PR.