DOC Use HTTPS for outside scripts/forms #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, sure - go wild on https :)
|
|
Well, a little less important now I see that https://nipy.github.io will be redirecting to the HTTP-only http://nipy.org, but I can go ahead and do this. How should I treat dead links? If I can find a new location, I'll change to that, but if not, should I leave them as is, mark as dead somehow, or remove them entirely? |
|
Why not remove them, and we'll all have a go at trying to find replacements
while we're reviewing the PR.
|
|
Nice - thanks very much for doing that. |
matthew-brett
added a commit
that referenced
this pull request
Jun 11, 2015
MRG: Use HTTPS for outside scripts/forms https instead of http for web links where possible.
grlee77
pushed a commit
to grlee77/nibabel
that referenced
this pull request
Mar 15, 2016
MRG: Use HTTPS for outside scripts/forms https instead of http for web links where possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
*.github.iopages support HTTPS, pulling in content from HTTP addresses causes browsers to complain about unsafe scripts. This eliminates any warnings, on a test I ran on one of our lab web servers. Loading scripts over HTTPS from an HTTP connection shouldn't cause problems.HTTPS might not be a priority for nibabel, so I limited this initial commit to making the nibabel site eliminate browser warnings. If it would be welcome, I can also go through other URLs throughout the documentation and upgrade them to HTTPS when they exist and have a valid certificate.