Fix an input and corresponding output in FIRST #1124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've written the theoretical names of outputs, however |
|
@satra @chrisfilo , I think this PR is ready to go. Even though I complain about the threshold method in my last update, I think it just doesn't work in the original script shipped with FSL. Documentation of the script doesn't help at all. Additionally, the alternative enum works well. With this PR, at least the interface can be used. |
chrisgorgo
added a commit
that referenced
this pull request
Jul 13, 2015
Fix an input and corresponding output in FIRST
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1123
Still necessary to check if output name changes with the input method.