Skip to content

fix: address multimodal and unimodal inputs #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 27, 2015
Merged

Conversation

satra
Copy link
Member

@satra satra commented Aug 27, 2015

@hjmjohnson - please check this.

should fix the multimodal and unimodal case.

@hjmjohnson
Copy link
Contributor

@satra This looks good. I can not test this week. I'll be happy to test next week.

@hjmjohnson
Copy link
Contributor

@satra To be clear. Happy if you merge.

@satra
Copy link
Member Author

satra commented Aug 27, 2015

@hjmjohnson - i'll merge, but please do test on your work when you get a chance.

we should also augment the metric description to support something like this.

metric specs:

Single input

fix = 'f_in1'
moving = 'm_in1'

'CC' - apply only to 1
['CC', 'Mattes'] - apply both to 1

Multiple inputs

fix = ['f_in1', 'f_in2', 'f_in3']
moving = ['m_in1', 'm_in2', 'm_in3']

'CC' - apply only to 1
['CC', 'CC'] - apply to 1, 2
['CC', None, 'CC'] - apply to 1 (CC), 3(CC)
[['CC', 'Mattes'], None, 'CC'] - apply to 1, 3, but apply CC, Mattes to 1, and CC to 3

for multiple inputs, we could also add an input arg apply_metric_all to handle the following scenario:

multiple inputs specified and apply_metric_all, 
'CC' - would get applied to 1, 2, and 3 

satra added a commit that referenced this pull request Aug 27, 2015
fix: address multimodal and unimodal inputs
@satra satra merged commit 6771823 into nipy:master Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants