-
Notifications
You must be signed in to change notification settings - Fork 535
Adjust expected bvecs/bvals filenames for the Philips DWI case #1266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BTW: Here is the story: nipy/heudiconv#13 |
Could you rebase or merge master? It seems you are triggering some errors that we have fixed in the meantime. |
@chrisfilo - both are failing on some conda issue, which michael didn't touch. and only on py2.7 |
CircleCI is failing on bedpostx (which were fixed in master). Travis errors might be due to other issues. |
@chrisfilo does circleci not do the testing on the merged pull request? |
CircleCI does not merge master into a PR branch before testing if this is what you are asking about. |
I can rebase this onto master, but I will not be able to test the result in the same way. Actually, it is just a single commit, no need for rebase. |
79b2dcc
to
edabcb0
Compare
Cherry-picked the commit and force-pushed... |
FTR: Don't think that the persisting failure has something to do with my patch. |
I fixed the travis failures and merged your other PR - we get some conflicts now. Could you look into this? |
edabcb0
to
e17b4e6
Compare
@chrisfilo Pushed rebase. |
dcm2nii removes a DWI volume and prefixes with 'x' accordingly.
Adjust expected bvecs/bvals filenames for the Philips DWI case
dcm2nii removes a DWI volume and prefixes with 'x' accordingly.
Note: Patch is against 0.11.0 -- last version that runs on Debian jessie, as python-future is not available as a package (AFAICS).