Skip to content

Conversation

Leoniela
Copy link
Contributor

Hi, I added a class to fslmaths to calculate the standard deviation in a voxel.

Here is the neurostars-thread about it:
https://neurostars.org/p/4004/

I already tried it out in my local nipype version in a workflow like this.
stdev = pe.Node(fsl.maths.StdImage(), name= 'Std_deviation_calculation')
The result looks good.

It is the first time I do something like this. Is this right? Also, I don't know, where I would have to add documentation. Feedback appreciated. Thanks, Leonie

"""Use fslmaths to generate a standard deviation in an image across a given dimension.
"""
input_spec = StdImageInput
_suffix = "_std"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the indentation here to line up with input_spec

@berleant
Copy link
Contributor

berleant commented Jun 15, 2016

Hi @Leoniela, nice to see you here too! Your contribution looks good to me. Before we merge your contribution, we need to make sure that the circleci test passes (see above). I didn't look too closely but I think git pull https://github.com/nipy/nipype.git master might fix it, because you haven't updated your repo from ours recently.

I would also like to see a test for your new code here (Again, you can probably follow -Tmax as a model.): https://github.com/Leoniela/nipype/blob/9f491b56a3588bb074159cbf983b1bd6dcbe141b/nipype/interfaces/fsl/tests/test_maths.py

@Leoniela
Copy link
Contributor Author

Hi @shoshber, thanks for the answer. I git pulled the master (updated mine), changed the indentation that had been messed up, and I added this test to the fsl/test/test_maths.py file (here I don't fully understand the code so I basically just copied the -Tmax snipped as you suggested and changed it accordingly - no warranty). Do I have to pull request again? How can I check this circleci test?

@berleant
Copy link
Contributor

The circleci tests run automatically when you add to any pull request--it looks like they failed again. Don't worry about the testing for now, @satra and I are looking into it

berleant pushed a commit to berleant/nipype that referenced this pull request Jun 17, 2016
@satra satra mentioned this pull request Jun 18, 2016
@satra
Copy link
Member

satra commented Jun 18, 2016

i've created a separate pull-request (#1518) that replaces this one. hopefully once it goes through testing, it will be ready for merge

@satra satra merged commit 4a62f9c into nipy:master Jun 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants