[Issue #1272] Input a list of warping regularization parameters to interfaces.spm.NewSegment #1590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -845,6 +845,8 @@ class NewSegmentInputSpec(SPMCommandInputSpec): | |||
| desc='mni, eastern, subj, none ') | |||
| warping_regularization = traits.Float(field='warp.reg', | |||
| desc='Aproximate distance between sampling points.') | |||
| warping_regularization_12 = traits.List(traits.Float(), minlen=5, maxlen=5, field='warp.reg', | |||
There was a problem hiding this comment.
this should likely be either or with warping_regularization. a couple of alternatives:
you can make warping regularization use traits.Either(traits.Float, traits.List(traits.Float, minlen, maxlen), desc= ...)
that may keep the interface cleaner. in the description you can add that the list of 5 elements is only supported in SPM 12.
There was a problem hiding this comment.
Great suggestion. Added & committed.
| traits.List(traits.Float(), | ||
| minlen=5, maxlen=5), | ||
| field='warp.reg' | ||
| desc='Warping regularization \ |
There was a problem hiding this comment.
instead of the \ you can simply create a tuple
desc=('Warping regularization parameter(s). '
'Accepts float or list of floats (the '
'latter being required by SPM12)')
|
Still new to the testing infrastructure. Unsure why CircleCI is failing. Looks like lots of isinstance() TypeFailures? |
1 similar comment
|
That worked! Tests passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to submit a list of warping regularization parameters to an spm.NewSegment routine, which appears to be required for some SPM12 workflows. This is a fix for Issue #1272.