Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Minor errors after migration to setuptools #1671

Merged
merged 8 commits into from
Oct 6, 2016

Conversation

oesteban
Copy link
Contributor

@oesteban oesteban commented Oct 5, 2016

  • Fixes nipype nosetests documentation broken #1670
  • Make sure matplotlib default backend is Agg in docker images
  • Do not use nipype.testing.assert_equal in nipype.interfaces.utility
  • update new fsl_course_data link in docs

@oesteban
Copy link
Contributor Author

oesteban commented Oct 5, 2016

I am also going to use OSF for hosting the test data files, since google drive is shutting down the api for direct downloads.

See: https://circleci.com/gh/nipy/nipype/1545

oesteban added a commit to oesteban/nipype that referenced this pull request Oct 5, 2016
@codecov-io
Copy link

codecov-io commented Oct 5, 2016

Current coverage is 70.95% (diff: 0.00%)

Merging #1671 into master will increase coverage by 6.58%

@@             master      #1671   diff @@
==========================================
  Files           232       1028     +796   
  Lines         36051      51607   +15556   
  Methods           0          0            
  Messages          0          0            
  Branches       4340       7315    +2975   
==========================================
+ Hits          23207      36618   +13411   
- Misses        12406      13900    +1494   
- Partials        438       1089     +651   

Powered by Codecov. Last update 91802ba...0b76680

@oesteban
Copy link
Contributor Author

oesteban commented Oct 5, 2016

@satra - please check these little changes and merge if ok

@satra
Copy link
Member

satra commented Oct 5, 2016

@oesteban - we should update the test command in the install docs as well. i can merge it right after that change since i know the tests pass. next up will be fixing doc building on readthedocs. we may need two separate requirements files.

@oesteban
Copy link
Contributor Author

oesteban commented Oct 6, 2016

@satra - I updated the makefile so that it runs the appropriate test command and also updated the documentation.

@satra satra merged commit b66ef0e into nipy:master Oct 6, 2016
@satra satra removed the in-progress label Oct 6, 2016
@oesteban oesteban deleted the fix/MinorErrorsNewInstaller branch October 6, 2016 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants