Better FSL modelgen parameter handling and a few more EV file parameters #1710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 69.90% (diff: 90.32%)@@ master #1710 diff @@
==========================================
Files 1028 1026 -2
Lines 50616 50502 -114
Methods 0 0
Messages 0 0
Branches 7333 7331 -2
==========================================
- Hits 35986 35305 -681
- Misses 13503 14021 +518
- Partials 1127 1176 +49
|
TheChymera
force-pushed
the
fsl_model
branch
2 times, most recently
from
b7fec7b to
9ab4075
Compare
this will make it easier to further parameterize the ev template files
TheChymera
force-pushed
the
fsl_model
branch
2 times, most recently
from
c7521be to
9eec092
Compare
|
As this PR's diff is quite wide-ranging, and as I cannot run the tests locally, I will be breaking this up into 2 PRs:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased PR #1693