Skip to content

Revert "[ENH] Move codecov to the end of each test #1889" #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 21, 2017

Conversation

oesteban
Copy link
Contributor

CircleCI environment variables were not set in the docker container, and it wasn't working. This PR reverts that situation (and also tries to make the coverage reporting more reliable).

@codecov-io
Copy link

codecov-io commented Mar 21, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@15f520d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1895   +/-   ##
=========================================
  Coverage          ?   70.93%           
=========================================
  Files             ?     1057           
  Lines             ?    53341           
  Branches          ?     7718           
=========================================
  Hits              ?    37837           
  Misses            ?    14125           
  Partials          ?     1379
Flag Coverage Δ
#smoketests 70.93% <ø> (?)
#unittests 70.38% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f520d...037254a. Read the comment docs.

@oesteban
Copy link
Contributor Author

@chrisfilo, since you were fighting with codecov some time ago, could you please take a look on this one? I think the codecov-io comment above is actually related to the fact that coverage has not been updated in master for a while.

@oesteban oesteban requested a review from chrisgorgo March 21, 2017 19:31
@chrisgorgo chrisgorgo merged commit f85dd1f into nipy:master Mar 21, 2017
@oesteban oesteban deleted the revert/Codecov branch March 21, 2017 21:34
@satra
Copy link
Member

satra commented Apr 15, 2017

@chrisfilo and @oesteban - codecov is again doing something weird - it's down to 46%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants