Skip to content

ENH: Add default transform, intensity scaling files to RobustTemplate #2141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2017

Conversation

effigies
Copy link
Member

@effigies effigies commented Aug 2, 2017

Changes proposed in this pull request

  • Allows transform_outputs=True and scaled_intensity_outputs=True to create files with default names, rather than pre-specifying.

From the docs:

OPTIONAL FLAGGED ARGUMENTS
	--lta <tp1.lta> <tp2.lta> ...
		output xforms to template (for each input)
[...]
	--iscaleout <is1.txt> <is2.txt> ...
		output final intensity scales (will activate --iscale)

@effigies effigies force-pushed the enh/template_default_outputs branch from ed4695f to 91dd1d2 Compare August 3, 2017 18:18
@codecov-io
Copy link

codecov-io commented Aug 3, 2017

Codecov Report

Merging #2141 into master will decrease coverage by 19.98%.
The diff coverage is 13.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #2141       +/-   ##
==========================================
- Coverage   72.18%   52.2%   -19.99%     
==========================================
  Files        1158     119     -1039     
  Lines       58020   23901    -34119     
  Branches     8334       0     -8334     
==========================================
- Hits        41884   12478    -29406     
+ Misses      14814   11423     -3391     
+ Partials     1322       0     -1322
Flag Coverage Δ
#smoketests 52.2% <13.33%> (-19.99%) ⬇️
#unittests ?
Impacted Files Coverage Δ
nipype/interfaces/freesurfer/longitudinal.py 64.86% <13.33%> (-19.52%) ⬇️
nipype/pipeline/plugins/callback_log.py 12% <0%> (-80%) ⬇️
nipype/workflows/smri/freesurfer/ba_maps.py 11.11% <0%> (-79.17%) ⬇️
nipype/workflows/rsfmri/fsl/resting.py 14.51% <0%> (-70.97%) ⬇️
nipype/workflows/smri/freesurfer/autorecon2.py 2.68% <0%> (-68.59%) ⬇️
nipype/workflows/smri/freesurfer/autorecon3.py 2.43% <0%> (-66.67%) ⬇️
nipype/pipeline/plugins/pbsgraph.py 29.41% <0%> (-64.71%) ⬇️
nipype/workflows/smri/freesurfer/bem.py 38.46% <0%> (-61.54%) ⬇️
nipype/interfaces/utility/csv.py 42.85% <0%> (-57.15%) ⬇️
nipype/workflows/smri/freesurfer/recon.py 9.28% <0%> (-56.43%) ⬇️
... and 1094 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b183b...7d271a8. Read the comment docs.

@satra satra merged commit af55be6 into nipy:master Aug 12, 2017
@effigies effigies deleted the enh/template_default_outputs branch October 5, 2017 20:33
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants