-
Notifications
You must be signed in to change notification settings - Fork 535
create_featreg_preproc: reference run modification #2190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2190 +/- ##
==========================================
+ Coverage 72.28% 72.31% +0.02%
==========================================
Files 1171 1172 +1
Lines 58622 58646 +24
Branches 8433 8436 +3
==========================================
+ Hits 42377 42407 +30
+ Misses 14887 14884 -3
+ Partials 1358 1355 -3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2190 +/- ##
==========================================
+ Coverage 72.28% 72.31% +0.02%
==========================================
Files 1171 1172 +1
Lines 58622 58647 +25
Branches 8433 8437 +4
==========================================
+ Hits 42377 42411 +34
+ Misses 14887 14881 -6
+ Partials 1358 1355 -3
Continue to review full report at Codecov.
|
else: | ||
return files[filemap[whichrun]] | ||
|
||
if isinstance(files, list): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps this if clause should be at the beginning to account for the potential that files is not a list, but a single filename.
Thanks for the remark, changes coming up |
Should now also work in case a single file (i.e. functional run) is given. |
ENH
Added possibility to specify which functional run the reference volume should be picked from to the function 'create_featreg_preproc'. The reference run can be selected by integer indexing or with a string ('first', 'middle', 'last') similar to how the reference volume is selected. Also added simple test functions respectively.
We ran an analysis with these changes on nipype version 0.11.0 and it worked fine.