Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Environment canonicalization bugs #2328

Merged
merged 1 commit into from Dec 2, 2017
Merged

FIX: Environment canonicalization bugs #2328

merged 1 commit into from Dec 2, 2017

Conversation

effigies
Copy link
Member

@effigies effigies commented Dec 2, 2017

Fixes #2326.

Changes proposed in this pull request

  • Correctly iterate over dict
  • Encode val, instead of key

Suspect we got away with this because Windows use is small.

@oesteban oesteban merged commit aee2e6e into master Dec 2, 2017
@oesteban oesteban deleted the fix-2326 branch December 2, 2017 15:41
@effigies effigies added this to the 1.0 milestone Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants