Skip to content

[FIX] Fix issue #2408 #2429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 8, 2018
Merged

[FIX] Fix issue #2408 #2429

merged 3 commits into from
Feb 8, 2018

Conversation

jguillon
Copy link
Contributor

@jguillon jguillon commented Feb 7, 2018

Fixes #2408.

Changes proposed in this pull request:

  • Change algorithm argument position

@djarecka
Copy link
Collaborator

djarecka commented Feb 7, 2018

@jguillon thanks for the PR. Two small things have to be changed:

mgxd
mgxd approved these changes Feb 8, 2018
View reviewed changes
Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@mgxd mgxd merged commit 50d1bfd into nipy:master Feb 8, 2018
@jguillon jguillon deleted the fix/dwi2response branch February 8, 2018 18:11
@effigies effigies added this to the 1.0.1 milestone Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgxd mgxd mgxd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@jguillon @djarecka @mgxd @effigies