Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tests #2451

Merged
merged 5 commits into from
Feb 19, 2018
Merged

Fix/tests #2451

merged 5 commits into from
Feb 19, 2018

Conversation

satra
Copy link
Member

@satra satra commented Feb 19, 2018

closes #2448

@satra satra requested a review from effigies February 19, 2018 15:51
effigies
effigies previously approved these changes Feb 19, 2018
>>> tbss.inputs.inputnode.skeleton_thresh = 0.2
>>> tbss.inputs.inputnode.fa_list = ['s1_wrapped_FA.nii', 's2_wrapped_FA.nii', 's3_wrapped_FA.nii']

>>> tbss = tbss.create_tbss_all('tbss', estimate_skeleton=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbss is the imported module. Maybe change the workflow vars to tbss_wf or similar?

@effigies effigies dismissed their stale review February 19, 2018 16:17

Failing tests

@codecov-io
Copy link

codecov-io commented Feb 19, 2018

Codecov Report

Merging #2451 into master will decrease coverage by 0.18%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2451      +/-   ##
==========================================
- Coverage    66.8%   66.61%   -0.19%     
==========================================
  Files         328      328              
  Lines       42456    42460       +4     
  Branches     5275     5277       +2     
==========================================
- Hits        28362    28284      -78     
- Misses      13406    13494      +88     
+ Partials      688      682       -6
Flag Coverage Δ
#smoketests 50.68% <ø> (ø) ⬆️
#unittests 63.94% <33.33%> (-0.31%) ⬇️
Impacted Files Coverage Δ
nipype/workflows/dmri/fsl/tbss.py 78.37% <33.33%> (-2.94%) ⬇️
nipype/interfaces/fsl/dti.py 66.22% <0%> (-10%) ⬇️
nipype/pipeline/plugins/multiproc.py 79.76% <0%> (-2.39%) ⬇️
nipype/interfaces/utility/base.py 88.2% <0%> (-1.69%) ⬇️
nipype/utils/profiler.py 43.1% <0%> (-1.15%) ⬇️
nipype/interfaces/fsl/utils.py 70.58% <0%> (-0.67%) ⬇️
nipype/interfaces/fsl/epi.py 65.18% <0%> (-0.5%) ⬇️
nipype/pipeline/engine/utils.py 82.29% <0%> (-0.46%) ⬇️
nipype/pipeline/engine/nodes.py 83.58% <0%> (-0.34%) ⬇️
nipype/interfaces/base/core.py 89.45% <0%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a374998...6a026ac. Read the comment docs.

@satra satra merged commit 1a1f9fd into nipy:master Feb 19, 2018
@effigies effigies added this to the 1.0.1 milestone Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

py.test takes much longer to run on circle relative to travis
3 participants