Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Check and report mount table parsing failures #2476

Merged
merged 2 commits into from Mar 7, 2018

Conversation

effigies
Copy link
Member

@effigies effigies commented Mar 1, 2018

Fixes #2473.

Follow-up to #2444 and #1941.

Changes proposed in this pull request

  • Log a debug message on parse failure.
  • Separate matching from retrieving, to enable error checking.
  • Ignore blank lines. These shouldn't happen, but we shouldn't be sensitive to them.
  • Simplify regular expression by enumerating stop conditions in fstype group.

@yarikoptic Can you verify this resolves your issue?

@effigies effigies added this to the 1.0.2 milestone Mar 1, 2018
@effigies
Copy link
Member Author

effigies commented Mar 1, 2018

Not sure why the Circle builds didn't post, but this is passing: https://circleci.com/workflow-run/25e6023f-7247-4043-bdde-fb1900a62809

@satra satra merged commit 88dbce1 into nipy:master Mar 7, 2018
@effigies effigies deleted the fix/mount_table_parse branch March 7, 2018 15:07
@yarikoptic
Copy link
Member

FWIW -- confirming that this fixed the build for me. Packages are still building but expect an upload of 1.0.1 (with this fix) to Debians later today if you care ;)

Thanks and Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash/difficulty while building docs
3 participants