Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagate explicit workflow config to nodes in a workflow and allow nodes to overwrite #2559

Merged
merged 1 commit into from
Apr 27, 2018

Conversation

satra
Copy link
Member

@satra satra commented Apr 27, 2018

Fixes # 2557.

Changes proposed in this pull request

  • Simply set the node config to None on initialization
  • This picks up the default when run is called.

@eort - please see if this branch solves your problem

@eort
Copy link
Contributor

eort commented Apr 27, 2018

@satra Yes, that solves it.

@codecov-io
Copy link

codecov-io commented Apr 27, 2018

Codecov Report

Merging #2559 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2559      +/-   ##
==========================================
+ Coverage   67.12%   67.14%   +0.01%     
==========================================
  Files         333      333              
  Lines       42538    42539       +1     
  Branches     5265     5265              
==========================================
+ Hits        28554    28563       +9     
+ Misses      13283    13274       -9     
- Partials      701      702       +1
Flag Coverage Δ
#smoketests 50.71% <100%> (+0.03%) ⬆️
#unittests 64.49% <100%> (+0.03%) ⬆️
Impacted Files Coverage Δ
nipype/pipeline/engine/nodes.py 84.29% <100%> (+0.35%) ⬆️
nipype/interfaces/base/specs.py 93.14% <0%> (-0.58%) ⬇️
nipype/pipeline/engine/utils.py 82.47% <0%> (+0.22%) ⬆️
nipype/utils/filemanip.py 78.3% <0%> (+0.23%) ⬆️
nipype/pipeline/plugins/multiproc.py 82.14% <0%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9315ca...fea03b8. Read the comment docs.

@effigies
Copy link
Member

@satra Should this go in before the release?

@satra
Copy link
Member Author

satra commented Apr 27, 2018

@effigies - it would be nice if it's not released yet, but i didn't want to hold back the release. i saw the pending PR for release.

@mgxd mgxd added this to the 1.0.3 milestone Apr 27, 2018
@effigies
Copy link
Member

My plan was to pass all tests today and push the button on Monday.

@effigies effigies merged commit 9333ff8 into nipy:master Apr 27, 2018
@effigies effigies mentioned this pull request Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants