Skip to content

FIX: Python 2.7-3.7.1 compatible NonDaemonPool #2754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2018
Merged

FIX: Python 2.7-3.7.1 compatible NonDaemonPool #2754

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
117c97b
FIX: Python 2.7-3.7.1 compatible NonDaemonPool
effigies Oct 25, 2018
5aea316
FIX: Empty lists for 3.4<=Python<3.7, missing import for 3.7
effigies Oct 25, 2018
8031fac
FIX: Full-on monkey patch
effigies Oct 25, 2018
c9a787e
STY: Cleanup + unused import [skip ci]
effigies Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions nipype/pipeline/plugins/legacymultiproc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

# Import packages
import os
from multiprocessing import Process, Pool, cpu_count, pool
from multiprocessing import Pool, cpu_count, pool
from traceback import format_exception
import sys
from logging import INFO
Expand Down Expand Up @@ -74,23 +74,23 @@ def run_node(node, updatehash, taskid):
return result


class NonDaemonProcess(Process):
"""A non-daemon process to support internal multiprocessing.
"""

def _get_daemon(self):
return False

def _set_daemon(self, value):
pass

daemon = property(_get_daemon, _set_daemon)


class NonDaemonPool(pool.Pool):
"""A process pool with non-daemon processes.
"""
Process = NonDaemonProcess
def Process(self, *args, **kwds):
proc = super(NonDaemonPool, self).Process(*args, **kwds)

class NonDaemonProcess(proc.__class__):
"""Monkey-patch process to ensure it is never daemonized"""
@property
def daemon(self):
return False

@daemon.setter
def daemon(self, val):
pass
proc.__class__ = NonDaemonProcess
return proc


class LegacyMultiProcPlugin(DistributedPluginBase):
Expand Down