Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Indices were swapped for memory and cpu profile data #2816

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

satra
Copy link
Member

@satra satra commented Dec 9, 2018

Summary

Fixes what looks like a swapped index.

List of changes proposed in this PR (pull-request)

change indices

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@satra satra requested a review from oesteban December 9, 2018 03:10
@codecov-io
Copy link

Codecov Report

Merging #2816 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2816   +/-   ##
=======================================
  Coverage   67.46%   67.46%           
=======================================
  Files         341      341           
  Lines       43331    43331           
  Branches     5371     5371           
=======================================
  Hits        29235    29235           
  Misses      13396    13396           
  Partials      700      700
Flag Coverage Δ
#smoketests 50.55% <0%> (ø) ⬆️
#unittests 64.87% <0%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/base/core.py 87.05% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eeabd3...fc9ff47. Read the comment docs.

@oesteban
Copy link
Contributor

oesteban commented Dec 9, 2018

OMG - Can we also address #2764 with this PR? (just adding the os.path.abspath).

@effigies effigies changed the title fix: indices were swapped for memory and cpu profile data [FIX] Indices were swapped for memory and cpu profile data Dec 13, 2018
@effigies effigies merged commit ab0bba7 into nipy:master Dec 13, 2018
@effigies effigies added this to the 1.1.7 milestone Dec 14, 2018
yarikoptic added a commit to yarikoptic/nipype that referenced this pull request Jan 11, 2019
1.1.7 (December 17, 2018)

* FIX: Copy node list before generating a flat graph (nipy#2828)
* FIX: Update pytest req'd version to 3.6 (nipy#2827)
* FIX: Set ResourceMonitor.fname to an absolute path (nipy#2824)
* FIX: Order of SPM.NewSegment channel_info boolean tuple is (Field, Corrected) (nipy#2817)
* FIX: Indices were swapped for memory and cpu profile data (nipy#2816)
* FIX: ``status_callback`` not called with ``stop_on_first_crash`` (nipy#2810)
* FIX: Change undefined ScriptError on LFS plugin to IOError (nipy#2803)
* ENH: Add NaN failure mode to CompCor interfaces (nipy#2819)
* ENH: Enable cnr_maps and residuals outputs for FSL eddy (nipy#2750)
* ENH: Improve ``str2bool`` + doctests (nipy#2807)
* TST: Improve py.test configuration of doctests (nipy#2802)
* DOC: Update DOI badge to point to all versions (nipy#2804)
* MAINT: Offload interfaces with help formatting (nipy#2797)
* MAINT: Reduce minimal code redundancy in filemanip.get_dependencies (nipy#2782)
* MAINT: Delayed imports to reduce import time (nipy#2809)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants