Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Refactor aggregate_outputs for readability #2969

Merged
merged 4 commits into from
Jul 29, 2019

Conversation

oesteban
Copy link
Contributor

@oesteban oesteban commented Jul 19, 2019

Just a rewrite for improved readability.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov-io
Copy link

codecov-io commented Jul 20, 2019

Codecov Report

Merging #2969 into master will decrease coverage by 3.37%.
The diff coverage is 65.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2969      +/-   ##
==========================================
- Coverage   67.61%   64.23%   -3.38%     
==========================================
  Files         344      342       -2     
  Lines       43798    43746      -52     
  Branches     5471     5468       -3     
==========================================
- Hits        29612    28102    -1510     
- Misses      13475    14549    +1074     
- Partials      711     1095     +384
Flag Coverage Δ
#smoketests ?
#unittests 64.23% <65.21%> (-0.8%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/base/core.py 84.46% <65.21%> (-2.45%) ⬇️
nipype/interfaces/nilearn.py 40% <0%> (-56.67%) ⬇️
nipype/utils/spm_docs.py 25.92% <0%> (-44.45%) ⬇️
nipype/interfaces/freesurfer/base.py 50% <0%> (-30.51%) ⬇️
nipype/utils/logger.py 59.7% <0%> (-29.86%) ⬇️
nipype/algorithms/rapidart.py 35% <0%> (-29.42%) ⬇️
nipype/interfaces/spm/base.py 57.94% <0%> (-29.14%) ⬇️
nipype/utils/provenance.py 55.73% <0%> (-28.35%) ⬇️
nipype/interfaces/fsl/model.py 55.26% <0%> (-25.35%) ⬇️
nipype/testing/fixtures.py 77.33% <0%> (-21.34%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3454c9a...259e7bc. Read the comment docs.

@oesteban oesteban marked this pull request as ready for review July 20, 2019 02:42
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine. I would strongly recommend against changing the exception types at this point, as it's just asking to break downstream code for very little benefit in clarity.

Two situations where you modify explicitly variables that would be modified implicitly by the functions that you pass them to. Feel free to reject those suggestions.

nipype/interfaces/base/core.py Outdated Show resolved Hide resolved
nipype/interfaces/base/core.py Outdated Show resolved Hide resolved
nipype/interfaces/base/core.py Outdated Show resolved Hide resolved
nipype/interfaces/base/tests/test_core.py Outdated Show resolved Hide resolved
oesteban and others added 2 commits July 26, 2019 09:16
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
@effigies effigies merged commit f02dd3a into nipy:master Jul 29, 2019
@oesteban oesteban deleted the enh/refactor-aggregate_outputs branch July 30, 2019 03:55
@effigies effigies added this to the 1.2.1 milestone Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants