Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore checking traits or bunch #3094

Merged
merged 2 commits into from Nov 12, 2019
Merged

Conversation

satra
Copy link
Member

@satra satra commented Nov 12, 2019

@Shotgunosine - can you see if this works?

@oesteban - this switches back to checking different kinds of results

@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #3094 into maint/1.3.x will decrease coverage by 5%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           maint/1.3.x   #3094      +/-   ##
==============================================
- Coverage         68.2%   63.2%   -5.01%     
==============================================
  Files              297     295       -2     
  Lines            39810   39733      -77     
  Branches          5218    5208      -10     
==============================================
- Hits             27152   25112    -2040     
- Misses           11941   13618    +1677     
- Partials           717    1003     +286
Flag Coverage Δ
#smoketests ?
#unittests 63.2% <100%> (-2.29%) ⬇️
Impacted Files Coverage Δ
nipype/pipeline/engine/nodes.py 76.74% <100%> (-6.54%) ⬇️
nipype/interfaces/dipy/stats.py 41.66% <0%> (-58.34%) ⬇️
nipype/interfaces/dipy/registration.py 41.66% <0%> (-58.34%) ⬇️
nipype/interfaces/nilearn.py 40% <0%> (-56.67%) ⬇️
nipype/workflows/__init__.py 47.05% <0%> (-52.95%) ⬇️
nipype/utils/spm_docs.py 25.92% <0%> (-44.45%) ⬇️
nipype/testing/fixtures.py 56% <0%> (-42.67%) ⬇️
nipype/interfaces/nitime/analysis.py 43.15% <0%> (-36.85%) ⬇️
nipype/interfaces/freesurfer/base.py 46.61% <0%> (-32.21%) ⬇️
nipype/interfaces/fsl/model.py 49.11% <0%> (-31.51%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c781a6...76e96fc. Read the comment docs.

@Shotgunosine
Copy link
Collaborator

Seems like it works now.

@effigies effigies merged commit 098d4b8 into nipy:maint/1.3.x Nov 12, 2019
@effigies
Copy link
Member

Thanks @Shotgunosine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants