Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: no more auto-failing on misparsed versions #3234

Closed
wants to merge 1 commit into from
Closed

ENH: no more auto-failing on misparsed versions #3234

wants to merge 1 commit into from

Conversation

TheChymera
Copy link
Collaborator

Fixes #3232

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@TheChymera TheChymera requested a review from satra August 7, 2020 05:14
@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #3234 into master will decrease coverage by 0.87%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3234      +/-   ##
==========================================
- Coverage   65.00%   64.12%   -0.88%     
==========================================
  Files         302      300       -2     
  Lines       39929    39868      -61     
  Branches     5279     5273       -6     
==========================================
- Hits        25956    25567     -389     
- Misses      12913    13251     +338     
+ Partials     1060     1050      -10
Flag Coverage Δ
#unittests 64.12% <50.00%> (-0.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/base/core.py 83.48% <50.00%> (-0.26%) ⬇️
nipype/workflows/__init__.py 47.05% <0.00%> (-52.95%) ⬇️
nipype/utils/spm_docs.py 20.00% <0.00%> (-48.00%) ⬇️
nipype/interfaces/freesurfer/base.py 47.58% <0.00%> (-28.23%) ⬇️
nipype/utils/logger.py 56.92% <0.00%> (-27.70%) ⬇️
nipype/testing/fixtures.py 77.92% <0.00%> (-20.78%) ⬇️
nipype/interfaces/dcm2nii.py 49.30% <0.00%> (-15.82%) ⬇️
nipype/interfaces/matlab.py 65.00% <0.00%> (-12.00%) ⬇️
nipype/interfaces/spm/base.py 58.08% <0.00%> (-9.58%) ⬇️
nipype/pkg_info.py 75.00% <0.00%> (-6.25%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5116ee2...d8aea1c. Read the comment docs.

3 similar comments
@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #3234 into master will decrease coverage by 0.87%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3234      +/-   ##
==========================================
- Coverage   65.00%   64.12%   -0.88%     
==========================================
  Files         302      300       -2     
  Lines       39929    39868      -61     
  Branches     5279     5273       -6     
==========================================
- Hits        25956    25567     -389     
- Misses      12913    13251     +338     
+ Partials     1060     1050      -10
Flag Coverage Δ
#unittests 64.12% <50.00%> (-0.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/base/core.py 83.48% <50.00%> (-0.26%) ⬇️
nipype/workflows/__init__.py 47.05% <0.00%> (-52.95%) ⬇️
nipype/utils/spm_docs.py 20.00% <0.00%> (-48.00%) ⬇️
nipype/interfaces/freesurfer/base.py 47.58% <0.00%> (-28.23%) ⬇️
nipype/utils/logger.py 56.92% <0.00%> (-27.70%) ⬇️
nipype/testing/fixtures.py 77.92% <0.00%> (-20.78%) ⬇️
nipype/interfaces/dcm2nii.py 49.30% <0.00%> (-15.82%) ⬇️
nipype/interfaces/matlab.py 65.00% <0.00%> (-12.00%) ⬇️
nipype/interfaces/spm/base.py 58.08% <0.00%> (-9.58%) ⬇️
nipype/pkg_info.py 75.00% <0.00%> (-6.25%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5116ee2...d8aea1c. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #3234 into master will decrease coverage by 0.87%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3234      +/-   ##
==========================================
- Coverage   65.00%   64.12%   -0.88%     
==========================================
  Files         302      300       -2     
  Lines       39929    39868      -61     
  Branches     5279     5273       -6     
==========================================
- Hits        25956    25567     -389     
- Misses      12913    13251     +338     
+ Partials     1060     1050      -10
Flag Coverage Δ
#unittests 64.12% <50.00%> (-0.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/base/core.py 83.48% <50.00%> (-0.26%) ⬇️
nipype/workflows/__init__.py 47.05% <0.00%> (-52.95%) ⬇️
nipype/utils/spm_docs.py 20.00% <0.00%> (-48.00%) ⬇️
nipype/interfaces/freesurfer/base.py 47.58% <0.00%> (-28.23%) ⬇️
nipype/utils/logger.py 56.92% <0.00%> (-27.70%) ⬇️
nipype/testing/fixtures.py 77.92% <0.00%> (-20.78%) ⬇️
nipype/interfaces/dcm2nii.py 49.30% <0.00%> (-15.82%) ⬇️
nipype/interfaces/matlab.py 65.00% <0.00%> (-12.00%) ⬇️
nipype/interfaces/spm/base.py 58.08% <0.00%> (-9.58%) ⬇️
nipype/pkg_info.py 75.00% <0.00%> (-6.25%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5116ee2...d8aea1c. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #3234 into master will decrease coverage by 0.87%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3234      +/-   ##
==========================================
- Coverage   65.00%   64.12%   -0.88%     
==========================================
  Files         302      300       -2     
  Lines       39929    39868      -61     
  Branches     5279     5273       -6     
==========================================
- Hits        25956    25567     -389     
- Misses      12913    13251     +338     
+ Partials     1060     1050      -10
Flag Coverage Δ
#unittests 64.12% <50.00%> (-0.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/base/core.py 83.48% <50.00%> (-0.26%) ⬇️
nipype/workflows/__init__.py 47.05% <0.00%> (-52.95%) ⬇️
nipype/utils/spm_docs.py 20.00% <0.00%> (-48.00%) ⬇️
nipype/interfaces/freesurfer/base.py 47.58% <0.00%> (-28.23%) ⬇️
nipype/utils/logger.py 56.92% <0.00%> (-27.70%) ⬇️
nipype/testing/fixtures.py 77.92% <0.00%> (-20.78%) ⬇️
nipype/interfaces/dcm2nii.py 49.30% <0.00%> (-15.82%) ⬇️
nipype/interfaces/matlab.py 65.00% <0.00%> (-12.00%) ⬇️
nipype/interfaces/spm/base.py 58.08% <0.00%> (-9.58%) ⬇️
nipype/pkg_info.py 75.00% <0.00%> (-6.25%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5116ee2...d8aea1c. Read the comment docs.

@satra
Copy link
Member

satra commented Aug 7, 2020

thanks @TheChymera - can we add a test for this by explicitly setting the version info of dummy interface to raise a type error and not to raise one.

mgxd
mgxd reviewed Aug 7, 2020
View reviewed changes
nipype/interfaces/base/core.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 8, 2020

Codecov Report

Merging #3234 into master will decrease coverage by 0.87%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3234      +/-   ##
==========================================
- Coverage   65.00%   64.12%   -0.88%     
==========================================
  Files         302      300       -2     
  Lines       39929    39868      -61     
  Branches     5279     5273       -6     
==========================================
- Hits        25956    25567     -389     
- Misses      12913    13251     +338     
+ Partials     1060     1050      -10
Flag Coverage Δ
#unittests 64.12% <50.00%> (-0.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/base/core.py 83.48% <50.00%> (-0.26%) ⬇️
nipype/workflows/__init__.py 47.05% <0.00%> (-52.95%) ⬇️
nipype/utils/spm_docs.py 20.00% <0.00%> (-48.00%) ⬇️
nipype/interfaces/freesurfer/base.py 47.58% <0.00%> (-28.23%) ⬇️
nipype/utils/logger.py 56.92% <0.00%> (-27.70%) ⬇️
nipype/testing/fixtures.py 77.92% <0.00%> (-20.78%) ⬇️
nipype/interfaces/dcm2nii.py 49.30% <0.00%> (-15.82%) ⬇️
nipype/interfaces/matlab.py 65.00% <0.00%> (-12.00%) ⬇️
nipype/interfaces/spm/base.py 58.08% <0.00%> (-9.58%) ⬇️
nipype/pkg_info.py 75.00% <0.00%> (-6.25%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5116ee2...b4d57d7. Read the comment docs.

@TheChymera
Copy link
Collaborator Author

@effigies @mgxd looking good? Tests seem to fail with some sort of permissions error :-/

@TheChymera
Copy link
Collaborator Author

@satra can you help me out here? As for the tests, I'm really unsure how to test this one :-/

@satra
Copy link
Member

satra commented Aug 11, 2020

@djarecka - could you please help @TheChymera over here. the test should simply focus on evaluating the min/max version check of a dummy interface. it shouldn't be specific to ants or any tool at all.

@effigies effigies mentioned this pull request Aug 14, 2020
Merged
12 tasks
@effigies effigies added this to the 1.5.1 milestone Aug 15, 2020
@effigies
Copy link
Member

Proposed a test and small refactor at TheChymera#2.

@effigies
Copy link
Member

If we want this in 1.5.1, please rebase onto maint/1.5.x.

@effigies effigies mentioned this pull request Aug 16, 2020
Merged
1 task
@effigies effigies closed this Aug 16, 2020
@TheChymera TheChymera deleted the versioncheck branch August 21, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies left review comments

@mgxd mgxd mgxd left review comments

@satra satra Awaiting requested review from satra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.

TypeError: '<' not supported between instances of 'int' and 'str'
4 participants
@TheChymera @satra @effigies @mgxd