Skip to content

Conversation

satra
Copy link
Member

@satra satra commented Aug 25, 2012

Preliminary PROV support in nipype

@chrisgorgo
Copy link
Member

Could you update the docs with a page explaining this feature?

@chrisgorgo
Copy link
Member

I'm happy to merge it, but we need some form of documentation.

from nipype.pipeline import write_prov
from nipype.external.provgraph import prov_to_file
g = write_prov(eg, 'workflow.json')
prov_to_file(g, 'workflow.pdf', use_labels=True, format='pdf')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You needto use a different example for this. I was trying to generete this graph, but it has been running for over 24h now...

satra added 27 commits August 10, 2013 18:04
* better artifact handling
* better capture of runtime info
@@ -1117,6 +1336,31 @@ def _process(drain=0):
return runtime


def get_dependencies(name, environ):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yarikoptic and @Hanke : could you suggest some better ways of getting at this info without hooking into extra dependencies? we can definitely improve this later, but this branch is otherwise in reasonable shape to merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but what do you mean by "this info"? ;)
if only a list of linked to libraries -- I guess, it could not be much better. If you actually want to "look inside" and figure out what other libraries/plugins this beast might be loading/opening (directly) then probably investigation of symbols provided elsewhere and associating them with one you can find used in this binary (like I believe https://github.com/rocksclusters/FingerPrint/blob/HEAD/FingerPrint/plugins/find-requires does) -- then there is more TODO.
If you actually want to get all dependencies needed during run-time, I guess you would need first to run the command via e.g. strace...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW hello @satra from Boston children museum's au bon pain (kids are running, I am working ;) )

@chrisgorgo
Copy link
Member

I'm happy to merge it, but we still need some (at least rudimentary) documentation.

@satra
Copy link
Member Author

satra commented Aug 12, 2013

@chrisfilo what kind of documentation would you like? in most cases this is still behind the scenes. we still need to build up apps on top of it (e.g. reporting). i could point to the nidm notebook somewhere. would that suffice for now? and that reminds me that i do need to add a nipype vocabulary guide. but i'll do that in a different pr.

@satra
Copy link
Member Author

satra commented Sep 8, 2013

@chrisfilo can i merge this?

@chrisgorgo
Copy link
Member

Go for it. Sorry for delay.

On Sun, Sep 8, 2013 at 8:01 PM, Satrajit Ghosh notifications@github.comwrote:

@chrisfilo https://github.com/chrisfilo can i merge this?


Reply to this email directly or view it on GitHubhttps://github.com//pull/451#issuecomment-24025809
.

satra added a commit that referenced this pull request Sep 8, 2013
@satra satra merged commit c021039 into nipy:master Sep 8, 2013
@satra satra deleted the enh/provenance branch September 8, 2013 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants