Skip to content

Conversation

dmwelch
Copy link
Contributor

@dmwelch dmwelch commented Nov 12, 2012

@chrisfilo, @satra, @hjmjohnson,

Added 3dDeconvolve() and Zeropad(), more traited flags to Allineate() and others, updated style to conform better with PEP8 (http://www.python.org/dev/peps/pep-0008/) and increased doctest usage.

The doctest usage may or may not conflict with the web documentation style. If so, I can move the offending tests to a doctest file, but I'll need help integrating that into the Nipype testing infrastructure.

Cheers,
@dmwelch

Erik Ziegler added 30 commits May 2, 2012 22:39
jessicaforbes and others added 22 commits November 30, 2012 14:19
BUG: Fixed afni.preprocess.to3D funcparams to not use the undocumented template for the argstr
ENH: Adding tpattern reading functionality to To3D()
BUG: Fixed bug for To3D() for output, To3D only returns AFNI output type (AFNI implementation)
STYLE: fixed typo in documentation and made more PEP8-compliant
BUG: Fixed file rename bug when copyfile is used for AFNI
STYLE: Removed attempt to use base class for prefix and suffix inputs
BUG: Fixed Refit() to correctly accept the output from To3D()
ENH: Added more options for Refit()
…c FIRST or you get weird errors running the pipeline
…ile_*'. Contact mailing list about the add_traits() function and how it should be correctly implemented. Doctesting and pipeline testing pass the cmdline generation, but the pipeline fails to add the argstr for the pipeline run (causing failure)
BUG: Fixed all calls to super(AFNICommand, self) to super(CLASSNAME, self)
…enerated by the stdout, not by the json file handling
@dmwelch dmwelch reopened this Feb 3, 2014
@chrisgorgo
Copy link
Member

This looks very messy, could you try to create a new branch (from current
master) and cherry pick the relevant commits?
On 3 Feb 2014 17:36, "David Welch" notifications@github.com wrote:

Reopened #479 #479.


Reply to this email directly or view it on GitHubhttps://github.com//pull/479
.

@dmwelch
Copy link
Contributor Author

dmwelch commented Feb 3, 2014

Sorry, @satra, I didn't see your reopen request…

@dmwelch
Copy link
Contributor Author

dmwelch commented Feb 3, 2014

@chrisfilo I'll see what I can do. I didn't want to lose the conversation...

@chrisgorgo
Copy link
Member

After cherry picking you can delete this branch (locally), rename the new
one so it would have the same name as the one that you have just removed,
and force push. This should preserve the discussion.
On 3 Feb 2014 17:42, "David Welch" notifications@github.com wrote:

@chrisfilo https://github.com/chrisfilo I'll see what I can do. I
didn't want to lose the conversation...


Reply to this email directly or view it on GitHubhttps://github.com//pull/479#issuecomment-33973075
.

@dmwelch
Copy link
Contributor Author

dmwelch commented Feb 7, 2014

@chrisfilo @satra I spent a couple of hours to cleaning up this. It's diverged from master quite a bit and I can't commit any more time to it. Sorry.

Dave

@hjmjohnson
Copy link
Contributor

This has become very stale. After two years since the start of this effort it still has not been polished to the point of being able to submit. Abandoning this pull request. If it becomes relevant in the future, someone else can make an effort to incorporate it.

@hjmjohnson hjmjohnson closed this Sep 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants