Skip to content

added versioning to traits and interfaces #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 17, 2012
Merged

added versioning to traits and interfaces #481

merged 11 commits into from
Dec 17, 2012

Conversation

satra
Copy link
Member

@satra satra commented Nov 17, 2012

No description provided.

satra added 8 commits November 17, 2012 18:11
@satra
enh: added versioning to traits and interfaces
ac6709b
@satra
fix: only check for version compatibility when inputs are defined
aa03d04
@satra
fix: version check and tests
b2c6696
@satra
enh: added version info to fsl, spm and freesurfer
89576e6
@satra
sty: pep8
1c9ee90
@satra
fix: resolved conflicts
9429806
@satra
enh: added output versioning as well
4c745fa
@satra
Merge branch 'master' into enh/versioning
5016d3e 
* master: (106 commits)
  Doctest fix, better error reporting.
  fix: config updated before checking for deprecated options
  put back the n_procs docs
  Udated docs with n_procs for MultiProc
  DOC: Improve docstring for DataFinder, include example usage.
  fix: adding atlases
  fix: removing recommends
  fix: restore fsl
  fix: remove fsl for now
  fix: variable name
  fix: use neurodebian sources
  fix: add missing nibabel
  fix: install nibabel in python dir
  fix: remove easy_install suffix
  fix: testing sklearn travis fix
  BF: Fixes for last commit
  BF: Use ignore regexes instead of functions so they can pickle.
  ENH: Added DataFinder interface.
  added cmdline example
  pep8
  ...
@satra
Copy link
Member Author

satra commented Dec 8, 2012

@chrisfilo, @mwaskom : ready for review

@chrisgorgo
Copy link
Member

Please describe "stop_on_unknown_version" option in the documentation.

How hard would it be to add the following two options (related):

  1. save version at runtime in reports/prov
  2. give an option to force rerun interfaces if version change has been detected.

satra added 2 commits December 9, 2012 14:08
@satra
Merge branch 'master' into enh/versioning
35781be 
* master:
  fix: deprecation warning does not reset trait to Undefined - will set new value
  add support for template files
  API fix for somaworkflow
  PEP8
  Further refactoring
  Reafactoring - less redundant code between SGE and PBS.
  Respect custom execution parameters in graph based models.
  DOC: Added docstring for MpiCommandLine with example usage.
  ENH: Provide base interface for MPI capable command line software.
@satra
doc: added version config info to doc
3387f42
@satra
Copy link
Member Author

satra commented Dec 9, 2012

  1. saving version does happen with the prov branch, this now allows an explicit version for each underlying interface. (i'll make sure this is cleaned up in the prov pr).
  2. rerunning based on versions gets tricky - for example, when spm runs do you want to rerun based on spm version or matlab version or both? and in the extreme, do you want the version of the underlying libraries to also trigger reruns? i think these are questions we don't have a good answer to right now but we want to design a system that allows us to consider these options - different levels of rerunning. (again, i think this should be a different pr).

@satra
Merge branch 'master' into enh/versioning
b77f3b4 
* master:
  fix: doctest carriage return
@mwaskom
Copy link
Member

mwaskom commented Dec 12, 2012

Cool! Looks good.

chrisgorgo added a commit that referenced this pull request Dec 17, 2012
@chrisgorgo
Merge pull request #481 from satra/enh/versioning
dc1e3e5 
added versioning to traits and interfaces
@chrisgorgo chrisgorgo merged commit dc1e3e5 into nipy:master Dec 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satra @chrisgorgo @mwaskom