Skip to content

Conversation

hjmjohnson
Copy link
Contributor

Numbers and punctuation are not valid job names.

Standard error:
Unable to run job: denied:
"99_SnapShotWriter_0000_0.BAW_20120813.johnsonhj" is not
a valid object name (cannot start with a digit).
Exiting.
Return code: 1

if testjobname[0].isalpha():
return testjobname
else:
return 'J'+testjobname
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small doctest + pep8 :)

@hjmjohnson
Copy link
Contributor Author

Satra,

Thanks for looking at this,

  1. I just made the pep8 changes. (Sorry)
  2. I don't understand what you want me to do for a doctest. I don't know what I should do.

Hans

def qsubSanitizeJobName(testjobname):
""" Qsub job names must begin with a
a letter. Numbers and punctuation are
not allowed. """
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace the doc string with this.

""" Ensure that qsub job names must begin with a letter.  

Numbers and punctuation are  not allowed. 

>>> qsubSantizeJobName('01')
'J01'
>>> qsubSantizeJobName('a01')
'a01'
"""

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed! Thanks for the tutoring.

hjmjohnson and others added 2 commits November 17, 2012 20:21
Numbers and punctuation are not valid job names.

Standard error:
Unable to run job: denied:
"99_SnapShotWriter_0000_0.BAW_20120813.johnsonhj" is not
a valid object name (cannot start with a digit).
Exiting.
Return code: 1

doc test added.
satra added a commit that referenced this pull request Nov 18, 2012
BUG:  SGE jobs must begin with an alhpa character
@satra satra merged commit 6929e80 into master Nov 18, 2012
@satra satra deleted the bug/FixQsubJobName branch December 25, 2013 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants