Fix/ants outputs #521
Merged
Fix/ants outputs #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| inverse_composite_transform = traits.List( | ||
| File(), desc='Inverse composite transform file') | ||
| File(exists=True), desc='Inverse composite transform file') |
There was a problem hiding this comment.
Chris,
I am not 100% sure, but I don't think that all 4 of these output transforms are required to exist. I think it is command line input dependent.
I cant test because I am at a conference this week. Go ahead and merge if you've confirmed that all 4 are mandatory outputs.
NOTE: These outputs are different ways to get the same transform (single file .h5 for composite, and multifile list for forward_transforms)
Hans
There was a problem hiding this comment.
This is slightly counter intuitive. It just checks if the file exists, but only if the value is set. Therefore it does not imply that the output is mandatory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hjmjohnson please have a look