ENH Increased flexibility in Function interface #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgorgo
added a commit
that referenced
this pull request
May 7, 2013
ENH Increased flexibility in Function interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow for more flexibility in using external Python functions in a Workflow. It allows you to provide a list of imports to Function so that functions that do not contain all imports within their body will run.
This is a relatively small change, but I don't feel like I full understand the motivation for the current constraints on how Function code works, so please check this to make sure I haven't violated those constraints. (It is tested, but not in the context of execution over a distributed system).
I still don't think this is ideal -- it would be best for a Node to infer what namespace elements it needs and deal with them itself -- but I believe it is a good improvement over the current requirements of the Function code.