Enh/glm #604
Enh/glm #604
Conversation
Conflicts: nipype/interfaces/fsl/__init__.py nipype/interfaces/fsl/model.py
| desc = 'file or image output') | ||
| out_file = File(exists=True, desc=('file name of GLM parameters' | ||
| + ' (if generated)')) | ||
| out_cope = OutputMultiPath(exists=True, desc='output file name for COPEs' + |
There was a problem hiding this comment.
are you sure these should be exists=True? a lot of them are filled under if statements.
There was a problem hiding this comment.
If left alone as Undefined even though exists=True they will not raise an error. Our own syntax is confusing us!
There was a problem hiding this comment.
so Undefined is ok, but if it is set, then the file must exist. i forgot that.
| outputs['out_file'] = os.path.abspath(outputs['out_file']) | ||
|
|
||
| if isdefined(self.inputs.out_cope): | ||
| outputs['out_cope'] = os.path.abspath(self.inputs.out_cope) |
There was a problem hiding this comment.
this implies that all the output names have to be specified for this node to return things. can we change this to genfile or name_source?
There was a problem hiding this comment.
These outputs are generated only if the corresponding output filenames are provided. This is a traits.Either(traits.Bool, File()) pattern that we should address in the refactor as well (by merging "source_name" with SEMLike). For now I would just merge it.
Integrating C-PACs FSLGLM into already existing GLM. As soon as this is merged I'll send a PR to C-PAC.