-
Notifications
You must be signed in to change notification settings - Fork 536
Add missing option apply_isoxfm to FSL Flirt wrapper #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d>' generated in the 3dAutomask command
… FLIRT but not wrapped in NiPype
Conflicts: nipype/interfaces/afni/preprocess.py
@@ -403,6 +403,8 @@ class FLIRTInputSpec(FSLCommandInputSpec): | |||
in_matrix_file = File(argstr='-init %s', desc='input 4x4 affine matrix') | |||
apply_xfm = traits.Bool(argstr='-applyxfm', requires=['in_matrix_file'], | |||
desc='apply transformation supplied by in_matrix_file') | |||
apply_isoxfm = traits.Float(argstr='-applyisoxfm %f', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we know if apply_xfm
and apply_isoxfm
can be used concurrently? if not we should add some xor
metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good point, they cannot be used concurrently. Do you have an example
of xor metadata that I could adapt to this case?
On Jul 8, 2013 4:54 PM, "Satrajit Ghosh" notifications@github.com wrote:
In nipype/interfaces/fsl/preprocess.py:
@@ -403,6 +403,8 @@ class FLIRTInputSpec(FSLCommandInputSpec):
in_matrix_file = File(argstr='-init %s', desc='input 4x4 affine matrix')
apply_xfm = traits.Bool(argstr='-applyxfm', requires=['in_matrix_file'],
desc='apply transformation supplied by in_matrix_file')
- apply_isoxfm = traits.Float(argstr='-applyisoxfm %f',
do we know if apply_xfm and apply_isoxfm can be used concurrently? if not
we should add some xor metadata.—
Reply to this email directly or view it on GitHubhttps://github.com//pull/605/files#r5075896
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, no matter how small the change i wanted to test it and for some reason the latest NiPype build wanted a few more packages (dipy, nipy, etc.) which gave me some troubles |
Please include the command line and error message.
|
It complained a lot about other packages missing, etc but in the end i could install all the dependencies. The only remaining issue is that despite having now dipy installed, i get a warning complaining about it not being installed from the
|
PS: This commit works fine. The warning only appears since i installed new packages. |
The warning is set to be generated when dipy is not ver 0.7.0 and this is actually the case since |
Any thing i should add to this PR? |
Add missing option apply_isoxfm to FSL Flirt wrapper
Before creating the function IsotropicReslicer, would it be possible to merge this quick fix which add the missing option apply_isoxfm to FSL Flirt wrapper?