Skip to content

Conversation

mick-d
Copy link
Contributor

@mick-d mick-d commented Jul 8, 2013

Before creating the function IsotropicReslicer, would it be possible to merge this quick fix which add the missing option apply_isoxfm to FSL Flirt wrapper?

@@ -403,6 +403,8 @@ class FLIRTInputSpec(FSLCommandInputSpec):
in_matrix_file = File(argstr='-init %s', desc='input 4x4 affine matrix')
apply_xfm = traits.Bool(argstr='-applyxfm', requires=['in_matrix_file'],
desc='apply transformation supplied by in_matrix_file')
apply_isoxfm = traits.Float(argstr='-applyisoxfm %f',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know if apply_xfm and apply_isoxfm can be used concurrently? if not we should add some xor metadata.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good point, they cannot be used concurrently. Do you have an example
of xor metadata that I could adapt to this case?
On Jul 8, 2013 4:54 PM, "Satrajit Ghosh" notifications@github.com wrote:

In nipype/interfaces/fsl/preprocess.py:

@@ -403,6 +403,8 @@ class FLIRTInputSpec(FSLCommandInputSpec):
in_matrix_file = File(argstr='-init %s', desc='input 4x4 affine matrix')
apply_xfm = traits.Bool(argstr='-applyxfm', requires=['in_matrix_file'],
desc='apply transformation supplied by in_matrix_file')

  • apply_isoxfm = traits.Float(argstr='-applyisoxfm %f',

do we know if apply_xfm and apply_isoxfm can be used concurrently? if not
we should add some xor metadata.


Reply to this email directly or view it on GitHubhttps://github.com//pull/605/files#r5075896
.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mick-d
Copy link
Contributor Author

mick-d commented Jul 9, 2013

Sorry for the delay, no matter how small the change i wanted to test it and for some reason the latest NiPype build wanted a few more packages (dipy, nipy, etc.) which gave me some troubles

@chrisgorgo
Copy link
Member

Please include the command line and error message.
On 9 Jul 2013 17:05, "Michael" notifications@github.com wrote:

Sorry for the delay, no matter how small the change i wanted to test it
and for some reason the latest NiPype build wanted a few more packages
(dipy, nipy, etc.) which gave me some troubles


Reply to this email directly or view it on GitHubhttps://github.com//pull/605#issuecomment-20680353
.

@mick-d
Copy link
Contributor Author

mick-d commented Jul 9, 2013

It complained a lot about other packages missing, etc but in the end i could install all the dependencies. The only remaining issue is that despite having now dipy installed, i get a warning complaining about it not being installed from the tensors.py file:

lib/python2.7/site-packages/nipype/interfaces/dipy/tensors.py:26: UserWarning: dipy not installed
  warnings.warn('dipy not installed')

@mick-d
Copy link
Contributor Author

mick-d commented Jul 9, 2013

PS: This commit works fine. The warning only appears since i installed new packages.

@mick-d
Copy link
Contributor Author

mick-d commented Jul 9, 2013

The warning is set to be generated when dipy is not ver 0.7.0 and this is actually the case since pip install dipy provides ver 0.6.0 (not 0.7.0.) as of today. So either the warning in tensors.py should be changed to match 0.6.0 either tensors.py indeed needs dipy ver 0.7.0 and in this case the dipy pip repository would need to be updated.

@mick-d
Copy link
Contributor Author

mick-d commented Jul 10, 2013

Any thing i should add to this PR?

satra added a commit that referenced this pull request Jul 10, 2013
Add missing option apply_isoxfm to FSL Flirt wrapper
@satra satra merged commit 050b889 into nipy:master Jul 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants