Fix for FUGUE interface #644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run autopep8 on preprocess.py. autopep8 would not correct some error though (those that might change code's behaviour, like breaklines) Note: I had a broken fork of nipype, disregard previous reference from commit. Close #642.
| if skip==None: | ||
| skip=[] | ||
| def _parse_inputs(self, skip=None): | ||
| if skip == None: |
There was a problem hiding this comment.
I did not change this from the original file, the autopep8 command added the spaces around the operators. I can change the definition to def _parse_inputs( self, skip=[] ): and remove the if.
There was a problem hiding this comment.
i much prefer skip=None followed by if skip is None (i just wanted to change from skip == None to skip is None
|
otherwise looks good. |
Regards #644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run autopep8 on preprocess.py. autopep8 would not correct some error
though (those that might change code's behaviour, like breaklines)
Note: I had a broken fork of nipype, disregard previous reference from
commit.
Close #642.