Skip to content

Conversation

satra
Copy link
Member

@satra satra commented Sep 8, 2013

No description provided.

satra and others added 30 commits August 12, 2013 13:23
…nh/restingwf

Conflicts:
	examples/rsfmri_preprocessing.py
* fix/mapnode:
  fix: added forced removal and running of multiple hashfiles
  fix: remove json files when rerunning a mapnode
  Add test for SelectFiles force_lists error
  Check that force_lists fields have templates
  Enhance flexibiliy of SelectFiles output list coercion
  without this, line 151 tries to call a module
…h/restingwf

Conflicts:
	examples/rsfmri_preprocessing.py
* master:
  tst: added test for extra json
  tst: added test for mapnode multiple json failure
  fix: remove only json hash files
  Fixed filenames in documentation
  Added dummy files so doctest doesn't fail
  PEP8 for the whole interface
  Run autopep8 on misc.py
  Added inputs&outputs descriptions
  Working version
  Base class for FuzzyOverlap misc tool
* master:
  doc: minimal provenance documentation
  Minor detail fixed
  Fix for FUGUE interface

For example:

python rsfmri_preprocessing.py -d /data/12345-34-1.dcm -f /data/Resting.nii -s subj001 -n 2 --despike -o output -p "plugin_args=dict(plugin='PBS', plugin_args=dict(qsub_args='-q many'))"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely seems like the -p argument here can be shortened and then handled internally. Why not just -p PBS and -q many? Having people write Python strings on the command line is just asking for annoying errors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the intent was to allow any nipype plugin to be used from the command line. i haven't figured out a good way to encapsulate those semantics.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But plugin just takes a string anyway. I agree the plugin_args are little harder to extract, but even just exposing a few general things (-queue, -nprocs) and leaving the option of of specifying the rest with a string seems better.

@mwaskom
Copy link
Member

mwaskom commented Sep 9, 2013

Looks like the dcmstack and dicom imports are still happening within a function...these are the most likely imports to cause problems as nipype doesn't (to my knowledge) have them as dependencies.

@satra
Copy link
Member Author

satra commented Sep 9, 2013

that's a regular python function. i can take those out. but they won't come through imports.

…e copied or not. in case inputs are directories, this will allow refreshing outputs.
* master:
  removed save_warped flag from FUGUE call since it doesn't seem to exist in the FUGUE interface
  try to determine output dir from fsf file, to deal with cases where the output dir is not in the cwd
@mwaskom
Copy link
Member

mwaskom commented Sep 10, 2013

I think i would continue to advocate for doing -plugin <plugin name> -args <python expression for plugin args> with sensible defaults for the main plugins. The current way is messy and not at all obvious to the user -- you'd have to actually read the code to understand how to use the -p flag; the argparse help string is not sufficient imo.

satra added a commit that referenced this pull request Sep 10, 2013
Example: Resting preprocessing workflow
@satra satra merged commit 0af3e6b into nipy:master Sep 10, 2013
@satra satra deleted the enh/restingwf branch September 10, 2013 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants