FIX: topup out_base and params #750
Conversation
|
@mluessi - could you please run |
|
@satra running "make spec" gives a huge number of modified files, is this correct? Also, I'm not sure how to enable travis.. we use it for MNE-Python but there it is set up for the main repo, not for my account.. |
|
is your branch synced with current master? otherwise goto -> settings -> service hooks -> scroll down and enable travis. |
|
@satra my master is up to date and there is a single commit on top of it. Looking at the diff, a lot of arguments and their order changed. Could it be that something else was recently changed and Regarding travis, you mean enable it for my nipype repo? Wouldn't it make more sense to enable it for nipy/nipype? Like that travis will automatically be run on each PR.. it's very nice (we use it for MNE-Python). |
|
it's already enabled for nipy/nipype - but when you enable for your fork, then it will do the testing automatically when you submit a pr or even when you just push to your branch. it could be that make specs wasn't run recently let me do that. |
|
@satra there must be a way to enable travis without me having to enable it as well. We use this setup in mne-python an no contributor ever had to enable travis for the tests being run on their PR. |
|
hmmm - can you figure that one out? are any of your contributors not part of the team and submitted a pr? |
|
@satra I'm looking at into it. Tests definitely run for PRs from people who are not on the team, e.g., As far as I can tell from the settings, we just enabled the travis service-hook in the settings. @agramfort did you have to change anything else to make travis run on each PR? |
|
no nothing special |
* master: Fixed file extension Fixed test files import. fixed possible values for -datatype parameter of tracks2prob interface. Previous values were in error. correct values obtained from: http://www.brain.org.au/software/mrtrix/general/formats.html#datatypes autogenerated tests added dummy files for testing new mrtrix interfaces updated CHANGES log Updated new mrtrix interfaces to new out_file format Added GenerateDirections, FindShPeaks, Directions2Amplitude interfaces wrapping gendir, find_SH_peaks and dir2amp mrtrix commands. tst: auto test generation for FUGUE fix: warp/unwarp arg parsing for use w/o an in_file fix: typo in fugue parameter add: pycharm .idea/ directory to .gitignore
Tst/martin
Fixes a bug in TOPUP and ApplyTOPUP where no output was saved unless the default value for
out_basewas used. In addition, full option names are used asmethodandinterpoptions were not recognized when using-m,-nto specify them.