-
Notifications
You must be signed in to change notification settings - Fork 535
Bug/fix ants initialization (when using only linear transforms) #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The generation of output filenames was incomplete for inverse outputs in both collapsed and not-collapsed modes. Additionally, collapsed mode for only-linear registrations was broken as the warp file was not generated (but checked for existence)
invert_flags in collapse mode got unexpected values (not boolean) for nonlinear transform
@oesteban - can you check why travis is failing? |
Sure, I looked at that, but did not find why it was failing:
They are identical (or, at least, I don't see the difference). As I was to write a test for the new feature, I'll see if I'm making a mistake that crashes the cmdline() |
Ok, that was it :). But now travis fails because it can't install afni ¿? |
@oesteban - that error is because the neurodebian server does not respond from time to time, right @yarikoptic @hjmjohnson - could you take a look at this PR? i think it looks good. |
@hjmjohnson - a quick peak would be appreciated :) |
I've found a case for which it fails, so please freeze this PR until I add the fix. |
On one hand, invert_initial_moving_transform was used and needed to be defined. On the other, as there is a xorg spec with initial_moving_transform_com, it was still failing.
I've checked that the PR now works OK. |
The generation of output filenames was incomplete for inverse outputs
in both collapsed and not-collapsed modes.
Additionally, collapsed mode for only-linear registrations was broken
as the warp file was not generated (but checked for existence)