Skip to content

Simplify input of a single LUT. Closes #726 #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2014

Conversation

chrisgorgo
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6e51c85 on chrisfilo:fix/camino_multipath into 2bc9ef0 on nipy:master.

@mick-d
Copy link
Contributor

mick-d commented Mar 10, 2014

@chrisfilo this is a very useful solution, i was always wondering what was the best way to deal with list of files which could also be a singleton. Would you recommend to use the InputMultiPath class in all these cases then? When i checked the doc for this class it was written "This should only be used as a final resort. We should stick to established Traits to the extent possible". So what would you advise to do? Try to avoid it or go with it in all cases inputs can be either a single file or a list of files?

@chrisgorgo
Copy link
Member Author

Interesting. I would use it whenever possible. It just makes life easier!
BTW did you test the solution?

On Mon, Mar 10, 2014 at 7:05 PM, Michael notifications@github.com wrote:

@chrisfilo https://github.com/chrisfilo this is a very useful solution,
i was always wondering what was the best way to deal with list of files
which could also be a singleton. Would you recommend to use the
InputMultiPath class in all these cases then? When i checked the doc for
this class it was written "This should only be used as a final resort. We
should stick to established Traits to the extent possible". So what would
you advise to do? Try to avoid it or go with it in all cases inputs can be
either a single file or a list of files?


Reply to this email directly or view it on GitHubhttps://github.com//pull/810#issuecomment-37214163
.

@mick-d
Copy link
Contributor

mick-d commented Mar 11, 2014

No i didn't have the chance to test it

chrisgorgo added a commit that referenced this pull request May 22, 2014
Simplify input of a single LUT. Closes #726
@chrisgorgo chrisgorgo merged commit 6c37d7f into nipy:master May 22, 2014
@chrisgorgo chrisgorgo deleted the fix/camino_multipath branch May 22, 2014 09:52
@chrisgorgo chrisgorgo restored the fix/camino_multipath branch June 7, 2014 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants