Skip to content

Conversation

satra
Copy link
Member

@satra satra commented Mar 30, 2014

@mwaskom, @matthew-brett, @sburns - this seems to fix the issues with pip

i'll pull over the package check stuff from @matthew-brett updates to nibabel.

a shufty would be much appreciated.

(closes #800)

@satra
Copy link
Member Author

satra commented Mar 31, 2014

nibabel's changes have been brought over.

one small adjustment regarding python-dateutil. the package installs as dateutil but pip needs to be called with pip install python-dateutil. the requirements file reflects this.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 13b57b9 on satra:fix/setup into 07143af on nipy:master.

@satra
Copy link
Member Author

satra commented Mar 31, 2014

@chrisfilo - i think this is ready for merge - but i'll let you review and merge.

@satra
Copy link
Member Author

satra commented Mar 31, 2014

any comments? otherwise i'll merge tomorrow.

@mwaskom
Copy link
Member

mwaskom commented Apr 1, 2014

It looks fine, as I said on the nibabel thread it feels very complex, but I guess that's what you need to accomplish the goals here. As long as it addresses the specific problem I opened #800 with, I say 👍

@chrisgorgo
Copy link
Member

Have you checked that it works with pypi, pip and easy_install?

@satra
Copy link
Member Author

satra commented Apr 1, 2014

pip, easy_install and setup.py - yes
pypi - i don't know how to test it without pushing the package there - which means making a release? do you know how?

@chrisgorgo
Copy link
Member

You can use testpypi https://wiki.python.org/moin/TestPyPI

On Tue, Apr 1, 2014 at 2:11 PM, Satrajit Ghosh notifications@github.comwrote:

pip, easy_install and setup.py - yes
pypi - i don't know how to test it without pushing the package there -
which means making a release? do you know how?


Reply to this email directly or view it on GitHubhttps://github.com//pull/825#issuecomment-39197899
.

satra added a commit that referenced this pull request Apr 2, 2014
fix: install to work with pip
@satra satra merged commit 0dad360 into nipy:master Apr 2, 2014
@satra satra deleted the fix/setup branch April 2, 2014 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nipype cannot be included in a requirements.txt file assuming an empty environment
4 participants