Skip to content

antsCorticalThickness.sh interface with example data #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 12, 2014
Merged

antsCorticalThickness.sh interface with example data #902

merged 12 commits into from
Sep 12, 2014

Conversation

armaneshaghi
Copy link
Contributor

Re-sending PR #884 with requested changes by @satra. Example data are just some files with size 0. All tests passed.

@armaneshaghi
Copy link
Contributor Author

sounds like Travis CI fails with a gpg related error from neurodebian, maybe we should ping @yarikoptic ?

gpgkeys: key 2649A5A9 not found on keyserver

@satra
Copy link
Member

satra commented Aug 30, 2014

@armaneshaghi - thanks for this. a lot of test files were regenerated, which should not be the case. this typically means you are not synced with upstream.

to fix:

  • (optional) revert the test files
  • merge upstream
  • redo make check-before-commit
  • commit and push.

@armaneshaghi
Copy link
Contributor Author

still includes garbage files. not really sure what I need to do. I'm synced with upstream. commit 85dc10e is the correct one, but when I hard reset to that commit, then there is no change to be pushed. Any ideas?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling d409f1c on armaneshaghi:master into 394ac0d on nipy:master.

desc='image dimension (2 or 3)')
anatomical_image=File(exists=True,
argstr='-a %s',
desc='Structural *intensity* image, typically T1.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i forgot to fix a few - could you please fix these. multiline description strings should be a tuple.

desc=('asdasd'
'qweqwe'
'123123')

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) when pulling 4e6561f on armaneshaghi:master into 394ac0d on nipy:master.

@armaneshaghi
Copy link
Contributor Author

@satra is this final from your point of view?

satra added a commit that referenced this pull request Sep 12, 2014
antsCorticalThickness.sh interface with example data
@satra satra merged commit 5215480 into nipy:master Sep 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants