Enh/tkregister2 #912
Merged
Enh/tkregister2 #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| >>> from nipype.interfaces.freesurfer import Tkregister2 | ||
| >>> tk2 = Tkregister2(reg_file='register.dat') | ||
| >>> tk2.inputs.moving_image = 'func.nii.gz' |
There was a problem hiding this comment.
These doctests are failing:
TraitError: The 'moving_image' trait of a Tkregister2InputSpec instance must be an existing file name, but a value of 'func.nii.gz' <type 'str'> was specified.
This is happening because there isn't a file called func.nii.gz in the test data directory (nipype/testing/data/). You can either set an existing filename (probably best) or create the name issuing touch func.nii.gz in that folder and adding the new file to the repository.
Same stuff for func2anat.mat
Other than that, this contribution is nice. Thanks a lot.
|
@oesteban thanks, i included the suggested modifications |
|
sorry, now the doctest passes but the autotest fails, guess i will have to go back to including the subjects_dir argument explicitly? |
|
@juhuntenburg - you just need to update with |
|
@satra great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding interface for Freesurfer tkregister2 command, so far only with basic functionality to convert fsl-style registration matrix to freesurfer-style matrix