Skip to content

Conversation

r03ert0
Copy link
Contributor

@r03ert0 r03ert0 commented Apr 3, 2020

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

Checklist

  • All tests passing
  • I have added tests to cover my changes
  • I have updated documentation (if necessary)
  • My code follows the code style of this project
    (we are using black: you can pip install pre-commit,
    run pre-commit install in the pydra directory
    and black will be run automatically with each commit)

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #229 into master will decrease coverage by 2.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
- Coverage   86.62%   83.74%   -2.88%     
==========================================
  Files          17       17              
  Lines        2885     2885              
  Branches      773      773              
==========================================
- Hits         2499     2416      -83     
- Misses        242      328      +86     
+ Partials      144      141       -3
Flag Coverage Δ
#unittests 83.74% <ø> (-2.88%) ⬇️
Impacted Files Coverage Δ
pydra/engine/workers.py 38% <0%> (-47.34%) ⬇️
pydra/__init__.py 65.62% <0%> (-6.25%) ⬇️
pydra/engine/submitter.py 87.5% <0%> (-3.85%) ⬇️
pydra/engine/helpers.py 87.67% <0%> (-1.9%) ⬇️
pydra/engine/task.py 79.52% <0%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba381d...3a7dde6. Read the comment docs.

@satra satra merged commit be16132 into nipype:master Apr 3, 2020
@satra satra mentioned this pull request Apr 3, 2020
@djarecka
Copy link
Collaborator

djarecka commented Apr 3, 2020

@r03ert0 - thank you! :)

@djarecka
Copy link
Collaborator

djarecka commented Jul 7, 2020

@r03ert0 - would you like to add your name to zenodo file? I can also add if you provide the info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants