Skip to content

Conversation

satra
Copy link
Contributor

@satra satra commented Apr 16, 2020

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

replaces the older etelemetry call with the latest simplified form

Checklist

  • All tests passing
  • I have added tests to cover my changes
  • I have updated documentation (if necessary)
  • My code follows the code style of this project
    (we are using black: you can pip install pre-commit,
    run pre-commit install in the pydra directory
    and black will be run automatically with each commit)

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #234 into master will decrease coverage by 1.94%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   86.58%   84.63%   -1.95%     
==========================================
  Files          17       17              
  Lines        2885     2812      -73     
  Branches      773      769       -4     
==========================================
- Hits         2498     2380     -118     
- Misses        242      277      +35     
- Partials      145      155      +10     
Flag Coverage Δ
#unittests 84.63% <100.00%> (-1.95%) ⬇️
Impacted Files Coverage Δ
pydra/__init__.py 93.33% <100.00%> (+24.58%) ⬆️
pydra/engine/task.py 65.60% <0.00%> (-14.72%) ⬇️
pydra/engine/audit.py 85.18% <0.00%> (-3.71%) ⬇️
pydra/engine/specs.py 88.30% <0.00%> (-3.25%) ⬇️
pydra/engine/helpers.py 88.15% <0.00%> (-1.43%) ⬇️
pydra/engine/helpers_state.py 88.43% <0.00%> (-0.97%) ⬇️
pydra/engine/state.py 93.97% <0.00%> (-0.65%) ⬇️
pydra/utils/profiler.py 37.69% <0.00%> (-0.48%) ⬇️
pydra/engine/core.py 89.09% <0.00%> (-0.34%) ⬇️
pydra/engine/graph.py 97.82% <0.00%> (-0.12%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be16132...34ecab8. Read the comment docs.

@satra
Copy link
Contributor Author

satra commented Apr 16, 2020

@nicolocin @djarecka - i'm merging this to master. this should fix doc building. so merge with your branches.

@satra satra merged commit 5fc78dd into master Apr 16, 2020
@effigies effigies deleted the ref-etelemetry branch July 7, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant