Skip to content

Conversation

basnijholt
Copy link
Contributor

@basnijholt basnijholt commented Aug 3, 2020

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

Checklist

  • All tests passing
  • I have added tests to cover my changes
  • I have updated documentation (if necessary)
  • My code follows the code style of this project
    (we are using black: you can pip install pre-commit,
    run pre-commit install in the pydra directory
    and black will be run automatically with each commit)

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #324 into master will decrease coverage by 3.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   85.81%   82.40%   -3.41%     
==========================================
  Files          20       19       -1     
  Lines        3476     3456      -20     
  Branches      927      925       -2     
==========================================
- Hits         2983     2848     -135     
- Misses        312      437     +125     
+ Partials      181      171      -10     
Flag Coverage Δ
#unittests 82.40% <ø> (-3.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/workers.py 33.33% <0.00%> (-44.28%) ⬇️
pydra/conftest.py 55.55% <0.00%> (-22.23%) ⬇️
pydra/engine/helpers.py 80.04% <0.00%> (-4.24%) ⬇️
pydra/engine/submitter.py 87.59% <0.00%> (-2.92%) ⬇️
pydra/engine/task.py 83.12% <0.00%> (-0.64%) ⬇️
pydra/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a696e11...4e40eec. Read the comment docs.

@djarecka djarecka merged commit 87f9e7a into nipype:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants