Skip to content

Conversation

djarecka
Copy link
Collaborator

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

  • adding generate_output_updates, to be able to predict names of the generated outputs before running

Checklist

  • All tests passing
  • I have added tests to cover my changes
  • I have updated documentation (if necessary)
  • My code follows the code style of this project
    (we are using black: you can pip install pre-commit,
    run pre-commit install in the pydra directory
    and black will be run automatically with each commit)

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #354 into master will decrease coverage by 0.17%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
- Coverage   85.86%   85.69%   -0.18%     
==========================================
  Files          20       20              
  Lines        3736     3761      +25     
  Branches     1007     1016       +9     
==========================================
+ Hits         3208     3223      +15     
- Misses        334      339       +5     
- Partials      194      199       +5     
Flag Coverage Δ
#unittests 85.69% <61.53%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/helpers_file.py 78.84% <ø> (ø)
pydra/engine/specs.py 86.92% <60.00%> (-1.19%) ⬇️
pydra/engine/core.py 88.10% <63.63%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01682de...b301171. Read the comment docs.

@djarecka djarecka changed the title [wip, mnt] nipype conversion updates [mnt] nipype conversion updates Oct 7, 2020
@djarecka djarecka merged commit b52a05b into nipype:master Oct 7, 2020
@djarecka djarecka deleted the mnt/nipype_interf_convert_cont branch December 30, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant