TST: Decrease divergence between Task/Workflow _run_task #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
==========================================
+ Coverage 79.03% 79.04% +0.01%
==========================================
Files 20 20
Lines 4345 4348 +3
Branches 1233 1231 -2
==========================================
+ Hits 3434 3437 +3
Misses 720 720
Partials 191 191
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mgxd
commented
Apr 1, 2022
pydra/engine/core.py
Outdated
| result = Result(output=None, runtime=None, errored=False) | ||
| self.hooks.pre_run_task(self) | ||
| result = self.prepare_run_task(rerun) | ||
| orig_outdir = self.output_dir |
There was a problem hiding this comment.
Task.output_dir is changing after the try/except block...
# before
/private/var/folders/r6/mcdps6rs37x2ttd1fn032yy40000gp/T/pytest-of-mathiasg/pytest-11/test_shell_cmd_inputspec_copyf0/ShellCommandTask_076520a92438002271a499fd2d1856333600d914bccc24b73505b69c61b77afb
# after
/private/var/folders/r6/mcdps6rs37x2ttd1fn032yy40000gp/T/pytest-of-mathiasg/pytest-11/test_shell_cmd_inputspec_copyf0/ShellCommandTask_f1303b44e112742de4622e902e48725b39bef257efe55f3195af27378ab02b8b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step to cleaning up some of the differences between
Task/Workflow