Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use functools.wraps in task decorator #533

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Apr 6, 2022

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

Ensures that the function name, location and docs of function tasks are not lost by the pydra.mark.task decorator

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #533 (418eca7) into master (92bc8c3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
+ Coverage   76.84%   76.85%   +0.01%     
==========================================
  Files          20       20              
  Lines        4284     4286       +2     
  Branches     1211     1211              
==========================================
+ Hits         3292     3294       +2     
  Misses        805      805              
  Partials      187      187              
Flag Coverage Δ
unittests 76.76% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/mark/functions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92bc8c3...418eca7. Read the comment docs.

@effigies
Copy link
Contributor

effigies commented Apr 6, 2022

LGTM

@effigies effigies merged commit 3a3e4bb into nipype:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants