New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spaces right before/after tag parentheses #71

Merged
merged 1 commit into from Aug 26, 2016

Conversation

Projects
None yet
4 participants
@dahlia
Member

dahlia commented Aug 25, 2016

This patch fixes #69.

The parser previously has a bug disallowing any whitespaces (including newline) right before and right after union tags' parentheses. For example, the previous parser doesn't accept the following union declaration:

union shape
    = circle (  // ⬅️ Newline/whitespaces not allowed ➡️
        point origin,
        offset radius,
        // ⬅️ Newline/whitespaces not allowed ➡️
      )
    | rectangle (  // ⬅️ Newline/whitespaces not allowed ➡️
        point upper-left,
        point lower-right,
        // ⬅️ Newline/whitespaces not allowed ➡️
    )
    | none
    ;
@Kroisse

This comment has been minimized.

Contributor

Kroisse commented Aug 26, 2016

💯

@dahlia dahlia merged commit e4c378c into nirum-lang:master Aug 26, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dahlia dahlia added the cmp:compiler label Aug 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment