Skip to content

Conversation

davemooreuws
Copy link
Member

@davemooreuws davemooreuws commented Jul 31, 2024

Closes #752

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 189 lines in your changes missing coverage. Please review.

Project coverage is 1.11%. Comparing base (022aff0) to head (4bd2b69).

Files Patch % Lines
pkg/cloud/sql/sql.go 0.00% 132 Missing ⚠️
pkg/dashboard/handlers.go 0.00% 39 Missing ⚠️
pkg/dashboard/dashboard.go 0.00% 18 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #760      +/-   ##
========================================
- Coverage   1.14%   1.11%   -0.03%     
========================================
  Files         79      79              
  Lines       8404    8589     +185     
========================================
  Hits          96      96              
- Misses      8298    8483     +185     
  Partials      10      10              
Flag Coverage Δ
unittests 1.11% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davemooreuws davemooreuws force-pushed the feat/sql-dashboard branch 5 times, most recently from 35d170b to 7058dcb Compare July 31, 2024 23:37
@jyecusch
Copy link
Member

jyecusch commented Aug 1, 2024

Found a couple small issues - decimal values appear as JSON and longer values get cut off. I'll try a few other data types to see what we get

Databases___Local_Dashboard___Nitric

@davemooreuws davemooreuws force-pushed the feat/sql-dashboard branch 2 times, most recently from e80e042 to 48a6e83 Compare August 1, 2024 05:10
jyecusch
jyecusch previously approved these changes Aug 2, 2024
@davemooreuws davemooreuws requested a review from jyecusch August 2, 2024 05:28
@davemooreuws davemooreuws merged commit 362c799 into main Aug 2, 2024
@davemooreuws davemooreuws deleted the feat/sql-dashboard branch August 2, 2024 05:31
@nitric-bot
Copy link
Contributor

🎉 This PR is included in version 1.49.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a SQL explorer or query UI to the local dashboard

5 participants