Skip to content

Conversation

davemooreuws
Copy link
Member

@davemooreuws davemooreuws commented Aug 12, 2024

Note: could cause a docker API error depending on if an older docker version is installed (would just require user to update their docker).

 Pull: Error response from daemon: client version 1.44 is too new. Maximum supported API version is 1.43

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 1.08%. Comparing base (616b343) to head (e1c22f4).

Files Patch % Lines
pkg/project/service.go 0.00% 4 Missing ⚠️
pkg/provider/image.go 0.00% 4 Missing ⚠️
pkg/cloud/sql/sql.go 0.00% 3 Missing ⚠️
pkg/docker/docker.go 0.00% 2 Missing ⚠️
pkg/provider/client.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #767      +/-   ##
========================================
- Coverage   1.08%   1.08%   -0.01%     
========================================
  Files         80      80              
  Lines       8884    8886       +2     
========================================
  Hits          96      96              
- Misses      8778    8780       +2     
  Partials      10      10              
Flag Coverage Δ
unittests 1.08% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davemooreuws davemooreuws marked this pull request as draft August 12, 2024 06:47
@davemooreuws davemooreuws marked this pull request as ready for review August 12, 2024 23:47
@davemooreuws davemooreuws merged commit 1723d34 into main Aug 13, 2024
@davemooreuws davemooreuws deleted the fix/upgrade-docker-dep branch August 13, 2024 00:51
@nitric-bot
Copy link
Contributor

🎉 This PR is included in version 1.50.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants