fix: stop exit status 1 printing for Go services #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjholm
previously approved these changes
Oct 7, 2024
davemooreuws
approved these changes
Oct 14, 2024
tjholm
approved these changes
Oct 14, 2024
|
🎉 This PR is included in version 1.54.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go services run with
nitric startoften print "exit status 1" on exit due to what seems to be a quirk of thego runcommand. See golang issue 13440.This change captures that exit status and prevent it from printing - since it's rarely a true error and there are other methods to debug real errors (e.g. build the service into a binary and/or container and test it).