Upgrade todomvc-nix into flake features. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ake.nix, and add go and rust binary to the development environment
…ll in shell.nix, and add sqitch for db migration
zimbatm
reviewed
Dec 2, 2020
shell.nix
Outdated
| let | ||
| pkgs = import ./nix {}; | ||
| in | ||
| { pkgs }: |
There was a problem hiding this comment.
this breaks when running nix-shell because there is no default value for pkgs.
There was a problem hiding this comment.
The best way to do this is similar to what you're doing in https://github.com/nix-community/nixpkgs-fmt/blob/master/shell.nix, but I still need to create mkshell.nix and import it here: https://github.com/nix-community/nixpkgs-fmt/blob/master/flake.nix#L34
I don't know, should we retain the non-flake-enabled Nix versions, given that we want to show Nix user how to use flake?
There was a problem hiding this comment.
I have update default.nix and shell.nix
Co-authored-by: Jonas Chevalier <zimbatm@zimbatm.com>
Co-authored-by: Jonas Chevalier <zimbatm@zimbatm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt to refactor all
todomvc-nixcode to use the flake feature. It's based on this #10 as a starter.What changed?
.devcontainerand.vscode/setting.jsonso that VSCode's user can useremote-containerplugin when playing with this project.envrcto make direnv work in the projectREADME.mdand addDocsfolder to narrow each architecture explanation..nixfile for future replacement (GitHub Actions in mind)